lingling
/
tiny-rdm
mirror of https://github.com/tiny-craft/tiny-rdm.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

perf: minimize the use of database switch commands

This commit is contained in:
Lykin 2023-12-29 00:16:25 +08:00
parent df3865dc7d
commit 4c9d75303c
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
backend/services/browser_service.go
View File

@ -57,6 +57,7 @@ type browserService struct {
ctx context.Context ctx context.Context
connMap map[string]*connectionItem connMap map[string]*connectionItem
cmdHistory []cmdHistoryItem cmdHistory []cmdHistoryItem
mutex sync.Mutex
} }
var browser *browserService var browser *browserService
@ -280,6 +281,9 @@ func (b *browserService) createRedisClient(selConn types.ConnectionConfig) (clie
// get a redis client from local cache or create a new open // get a redis client from local cache or create a new open
// if db >= 0, will also switch to db index // if db >= 0, will also switch to db index
func (b *browserService) getRedisClient(server string, db int) (item *connectionItem, err error) { func (b *browserService) getRedisClient(server string, db int) (item *connectionItem, err error) {
b.mutex.Lock()
defer b.mutex.Unlock()
var ok bool var ok bool
var client redis.UniversalClient var client redis.UniversalClient
if item, ok = b.connMap[server]; ok { if item, ok = b.connMap[server]; ok {
@ -307,8 +311,8 @@ func (b *browserService) getRedisClient(server string, db int) (item *connection
} }
// BUG: go-redis might not be executing commands on the corresponding database // BUG: go-redis might not be executing commands on the corresponding database
// requiring a database switch with each command // requiring a database switch before execute each command
if db >= 0 /*&& item.db != db*/ { if db >= 0 && item.db != db {
var rdb *redis.Client var rdb *redis.Client
if rdb, ok = client.(*redis.Client); ok && rdb != nil { if rdb, ok = client.(*redis.Client); ok && rdb != nil {
_, err = rdb.Pipelined(item.ctx, func(pipe redis.Pipeliner) error { _, err = rdb.Pipelined(item.ctx, func(pipe redis.Pipeliner) error {